Re: [PATCH 3/6] d3dx9: D3DXQuaternionSquadSetup should support arguments aliasing.

[Matteo Bruni]

2016-04-14 14:10 GMT+02:00 Paul Gofman :

Neither of those are your faults, but since you're at it...
> - if ( D3DXQuaternionDot(pq0, pq1) <  0.0f )
> - if (D3DXQuaternionDot(pq0, pq1) <  0.0f)
>     temp2 = add_diff(&zero, pq0, -1.0f);
> else
>     temp2 = *pq0;

also remove the double space.
> @@ -1634,7 +1635,9 @@ void WINAPI D3DXQuaternionSquadSetup(D3DXQUATERNION *paout, D3DXQUATERNION *pbou
>      temp1.z *= -0.25f;
>      temp1.w *= -0.25f;
>      D3DXQuaternionExp(&temp1, &temp1);
> - D3DXQuaternionMultiply(pbout, pcout, &temp1);
> -
>
> D3DXQuaternionMultiply(pbout, &cout, &temp1);
> -
>
> *paout = aout;
> -
>
> *pcout = cout;
>
> return;
>
> }

Please also remove the unnecessary return.