Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.

[El.]

> "El."  wrote:
> > @@ -4606,6 +4606,10 @@ static LRESULT EDIT_WM_KeyDown(EDITSTATE *es, INT key)
> >      {
> >    HWND hwndParent = GetParent(es->hwndSelf);
> >    DWORD dw = SendMessageW( hwndParent, DM_GETDEFID, 0, 0 );
> > -
> > - if (GetClassLongW(hwndParent, GCW_ATOM) != WC_DIALOG)
> > -
> >  break;
>
> You need to add a test case first to confirm that the fix is correct, and
> use EDIT_IsInsideDialog to detect if the parent is dialog.

Well I'm not sure what to test in the first place, I didn't assume that
modifying some aspect of the code to be in compliance with official
"standards" required writing any test case.

I might be missing what you mean by the "correctness" of the fix,
since I'm not really familiar with Wine's patching practices.

http://msdn2.microsoft.com/en-us/library/bb775464(VS.85).aspx

As for using EDIT_IsInsideDialog, that I can manage.