Re: include: fix mingw64 build

[Jacek Caban]

On 07/15/12 14:21, Nicolas Le Cam wrote:
> 2012/7/4 Jacek Caban :
> > On 07/03/12 20:10, Jacek Caban wrote:
> > > On 06/29/12 03:35, Austin English wrote:
> > > > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam  wrote:
> > > > > 2012/6/29 Austin English :
> > > > > > Fixes http://bugs.winehq.org/show_bug.cgi?id=30980
> > > > > >
> > > > > > --
> > > > > > -Austin
> > > > >
> > > > > Hi Austin,
> > > > >
> > > > > I already tried to fix it on Wine side, see [1],
> > > > > but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64,
> > > > > as it shouldn't include crtdefs.h by default.
> > > > >
> > > > > BTW, won't that break mingw32 build ?
> > > > >
> > > > > [1] http://source.winehq.org/patches/data/84070
> > > > >
> > > > > --
> > > > > Nicolas Le Cam
> > > >
> > > > Thanks for the info. Have you or anyone else discussed this with
> > > > mingw64? I did a quick search on their bugtracker, but don't see
> > > > anything..
> > > > http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=a...
> > >
> > > FWIW, here is my proposed patch to mingw-w64:
> > >
> > > http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/5db96424c7b9ac4aa5a66bd0e...
> > >
> > > We will see if they like it.
> >
> > The (extended) fix is in mingw-w64 SVN now.
> >
> > Jacek
>
> Hi Jacek,
>
> Could it be backported into stable 2.x ? This will allow distros to
> package it with the next stable release of mingw-w64.

I'm not sure bout that, it's quite an invasive change, so it may be too
risky for stable branch. I'm CCing mingw-w64 ML to see what maintainers
think.

BTW, our Wine Gecko package requires trunk version, so distros compiling
it themselves have provide its packages anyway (I don't really follow it
close enough to have more details). It may be a good idea to use this
version for Wine development.

Jacek