Re: [PATCH] mshtml: Add better stub for HTMLDocument7::get_onmsthumbnailclick.

[Jacek Caban]

Hi Dmitry,

On 6/14/19 12:46 PM, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov
>
> dlls/mshtml/htmldoc.c   | 3 ++-
>   dlls/mshtml/tests/dom.c | 7 +++++++
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c
> index 868a9a0048..ee1492d83b 100644
> --- a/dlls/mshtml/htmldoc.c
> +++ b/dlls/mshtml/htmldoc.c
> @@ -3340,7 +3340,8 @@ static HRESULT WINAPI HTMLDocument7_get_onmsthumbnailclick(IHTMLDocument7 *iface
>   {
>       HTMLDocument *This = impl_from_IHTMLDocument7(iface);
>       FIXME("(%p)->(%p)\n", This, p);
> - return E_NOTIMPL;
> - V_VT(p) = VT_NULL;
> - return S_OK;

We have a mechanism in place for such stubs, see EVENT_FIXME in events 
like beforeactivate.

Thanks,

Jacek