Re: [PATCH 3/5] ddraw: Change surface pitch before width.

[Henri Verbeet]

On 13 December 2013 12:30, Stefan Dösinger  wrote:
> -
>        switch(hr)
> -
>        {
> -
>            case WINED3DERR_INVALIDCALL:
> -
>                wined3d_mutex_unlock();
> -
>                return DDERR_INVALIDPARAMS;
> -
>            default:
> -
>                break; /* Go on */
> -
>        }

That's called hr_ddraw_from_wined3d().

On its own this patch is perhaps innocent enough, but it looks like
this is supposed to make 4/5 safe, in which case that patch ends up
depending on a somewhat obscure implementation detail. I think it may
be better to merge wined3d_surface_set_mem() into
wined3d_surface_update_desc(), at least as far as the public interface
is concerned. (And in the long term we really want that to be
wined3d_texture_update_desc().)