On 5/13/19 8:14 PM, Alexandre Julliard wrote:
Jacek Caban jacek@codeweavers.com writes:
Allows returning to caller arbitrary status including values that would be otherwise have special meaning for client.
That series doesn't look very nice. Do we really need all that complexity?
It seems to me it would be easier to use some different status values just for the async case, and leave the rest of the code alone.
Part of my consideration was that the problem is not limited to pending return. Errors reported by IRP dispatcher may also need to return status code without touching status block. select complication is indeed not pretty, but server_*_file part seems nice. I attached patches implementing pending blocking for the context.
I also attached tests showing possible further problem with errors. I didn't implement the error behaviour and I'm not aware of an application that needs this, but on top of that series it should not need more protocol changes. Anyway, I will look for less invasive solution if you prefer.
Thanks,
Jacek