Re: [PATCH] msvcrt: fix character/byte confusion in buffer overflow branch

[Max Kellermann]

On 2013/05/07 17:46, Juan Lang  wrote:
> In general, I think you want to send this to wine-patches, not here.

True, I resent it to wine-patches yesterday already, when I noticed
that.
> >  if(out->len < len) {
> > -
> >    memcpy(out->buf, str, out->len);
> > -
> >    memcpy(out->buf, str, out->len*sizeof(APICHAR));
> >    out->buf += out->len;
>
> If the memcpy was incorrect, the += is also incorrect. I'm not sure which
> is the case, but either way, your patch can't be correct as is.

Sure?

out->buf is an "APICHAR*" (see printf.h), and adding out->len advances
the pointer by "out->len * sizeof(APICHAR)" bytes.

Am I missing something?

Max