Re: [PATCH 1/4] msvcp90: Added basic_string<char>::append(size_t, char) implementation.

[Piotr Caban]

Hi,

On 04/18/11 23:53, Vincas Miliūnas wrote:
> My remark: (The method is implemented by reusing existing code) this->size+count<this->size is the same as count<  0 and throwing a "string too long" exception in that case is not semantic.

count is an unsigned variable so it cannot be smaller then 0. My 
intention was to make sure there's no overflow. This check is not needed 
because MSVCP_basic_string_char_npos-this->size <= count already makes 
sure this->size+count has small enough value.

+basic_string_wchar* __thiscall MSVCP_basic_string_wchar_append_len_wchar(
+        basic_string_wchar *this, size_t count, wchar_t c)
+{
+    TRACE("%p %lu %lc\n", this, (unsigned long)count, c);
It's probably not allowed to use %lc format.

Cheers,
Piotr