On 3/21/22 18:55, Zebediah Figura wrote:
On 3/21/22 03:42, Rémi Bernon wrote:
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45988 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47084 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49715 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52183 Signed-off-by: Rémi Bernon rbernon@codeweavers.com
dlls/winegstreamer/wg_transform.c | 33 ++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-)
As far as I'm aware, the only reason to use a GstBufferList is to reduce the overhead of pushing multiple buffers simultaneously. Can you please add an explanation, either in the commit message or (ideally) in the code?
It also, and primarily, lets us keep multiple input buffers queued without having to reimplement a buffer list, as the H264 transform behavior, expected by some games, and the tests, require it.
I can add a comment I guess.