Re: [PATCH] dbghelp: Make SymGetLineFromAddr64 call SymGetLineFromAddrW64

[Alistair Leslie-Hughes]

On 11/03/17 03:26, Sebastian Lackner wrote:
> On 10.03.2017 04:24, Alistair Leslie-Hughes wrote:
> > Signed-off-by: Alistair Leslie-Hughes
> >
> > dlls/dbghelp/dbghelp_private.h |  3 ++
> >  dlls/dbghelp/symbol.c          | 96 ++++++++++++++++++++++++++++++------------
> >  2 files changed, 73 insertions(+), 26 deletions(-)
>
> Could you give some explanation for the purpose of this patch? It looks a bit odd that
> we need two almost identical symt_fill_func_line_info implementations.

The function stabs_finalize_function in stabs.c uses this function.
However updating this as well started a snowball if changes, making the
patch too large.  The symt_fill_func_line_info should be able to be
removed once the symt_get_func_line_next is updated to with a similar
change as this one.

Best Regards
Alistair