Re: [PATCH 1/3] qasf/tests: Fix a test failure with Windows 2003.

[Zebediah Figura]

On 3/21/20 8:55 PM, Francois Gouget wrote:
> [...]
> > @@ -1707,7 +1707,7 @@ static void test_streaming_events(IMediaControl *control, IPin *sink, IMemInputP
> >      todo_wine ok(testsink2->got_eos == 1, "Got %u calls to IPin::EndOfStream().\n", testsink2->got_eos);
> >  hr = IMemInputPin_Receive(input, sample);
> > - todo_wine ok(hr == VFW_E_SAMPLE_REJECTED_EOS, "Got hr %#x.\n", hr);
> > - todo_wine ok(hr == S_FALSE /* 2003 */ || hr == VFW_E_SAMPLE_REJECTED_EOS, "Got hr %#x.\n", hr);
>
> Should there be a broken() somewhere around here?

The documentation doesn't specify, and at least some other filters
return S_FALSE here even in newer Windows, so it's not really clear to
me that either case should be considered broken. But I don't feel
strongly about it.