Re: RFC: Richedit: Test Patch for EM_SETMARGINS

[James McKenzie]

On 1/17/11 1:07 AM, Dmitry Timoshkov wrote:
> James McKenzie  wrote:
> > - ok (16 == sentLogFontA.lfHeight, "Height not set to 12 for System Font. Height is %d\n", sentLogFontA.lfHeight);
>
> 12?

Fixed in the next test patch.
> > - ok (96 == ry, "DPI for screen does not equal 96 it is %d\n", ry);
> > - ok (-240 == CharFont1ANSI.yHeight /* Wine */|| 195 == CharFont1ANSI.yHeight /* Windows */, "y Height of System Character is "
> > -
> >    "not -240 or 195 but is %d\n", CharFont1ANSI.yHeight);
> > - ok (16 == abs(CharFont1ANSI.yHeight) * ry / 1440 /*Wine*/|| 13 == abs(CharFont1ANSI.yHeight) * ry / 1440 /*Windows*/, \
> > -
> >    "Character Height of System character set is not 16 but %d\n", abs(CharFont1ANSI.yHeight) * ry / 1440);
> > - ok (0 == CharFont1ANSI.yOffset, "Character Offset for System character set is not zero but %x\n", CharFont1ANSI.yOffset);
> > - ok (7 == tma.tmAveCharWidth, "Average Character Width for System character set is %d\n", tma.tmAveCharWidth);
> > - ok (15 == tma.tmMaxCharWidth /*Wine*/ || 14 == tma.tmMaxCharWidth /*Windows*/, "Maximum Character Width for System character set " \
> > -
> >    "is %d\n", tma.tmMaxCharWidth);
>
> Please use normal not reversed comparisons here and everywhere else, that
> style improves nothing.

Actually this did catch an error where I used equal (=) instead of equal 
to (==) and that is a couple of best coding practice books that I use.  
However, for the final patch, this will be removed in its entirety.  
There is a difference between what Windows is returning and what Wine is 
returning but that is not the purpose of this patch.

James McKenzie