-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
There are a few more issues:
Am 2015-04-02 um 18:36 schrieb Aaryaman Vasishta:
- Copyright 2012 Andr� Hentschel
- Copyright 2011-2014 Henri Verbeet for CodeWeavers
The encoding is still messed up.
Is there any code you have taken from the other file? test_qi() is from dlls/ddraw/tests/ddraw*.c, so you should keep Henri's line. Taking along all the Copyright lines if you take something from an existing file is a safe choice though. Also, you should still fix your editor settings anyways.
You can add your own name there if you want.
(Fwiw, I don't know why we're maintaining these lines at all. The last thing I heard was that they don't have any legal meaning anyway. Also, git keep track of authorship pretty well.)
+#define CHECK_REFCOUNT(obj,rc) \
- { \
- int rc_new = rc; \
- int count = get_refcount((IUnknown *)obj); \
- ok(count == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, count); \
- }
Do you need this? You're using this in one place as far as I can see, you can also just use the get_refcount() and ok() calls directly.
+static int get_refcount(IUnknown *object) +{
- IUnknown_AddRef(object);
- return IUnknown_Release(object);
+}
Refcounts are ULONG.
- hr = IDirect3DRM_CreateFrame(d3drm, NULL, &frame);
- ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame3 interface (hr = %x)\n", hr);
The string is a bit misleading, I think something like "Failed to create frame" is better. Not a big issue though.
The same applies to d3drm2.c and d3drm3.c