Re: registry patch

[Tony Lambregts]

Matthieu Foillard wrote:
> Hi,
>
> this fix a bug when data is null. 
> (3dsmax v3 now works with this)
> Note that i'm not a wine developper and this patch might not be the right
> way to fix the problem. Someone on #winehq told me this is acceptable so...
> Index: dlls/advapi32/registry.c
>
> RCS file: /home/wine/wine/dlls/advapi32/registry.c,v
> retrieving revision 1.50
> diff -u -3 -p -r1.50 registry.c
> --- dlls/advapi32/registry.c    20 Jan 2003 23:23:12 -0000      1.50
> +++ dlls/advapi32/registry.c    14 Feb 2003 22:49:13 -0000
> @@ -902,7 +902,7 @@ DWORD WINAPI RegSetValueExA( HKEY hkey,
> if (!is_version_nt())  /* win95 */
> {
> -
>    if (type == REG_SZ) count = strlen(data) + 1;
> -
>    if (type == REG_SZ && data != NULL) count = strlen(data) + 1;
> }
>   else if (count && is_string(type))
>   {

I have waited for someone else to comment on this patch since I am not 
really very familiar with this portion of the code.  I am not sure if 
this is the right way to fix this. What I really want to know is what is 
the value of count when the data is null.