On Mon, Jan 26, 2009 at 6:03 AM, Alexandre Julliard julliard@winehq.org wrote:
Lei Zhang thestig@google.com writes:
Hi,
This fixes bug 17103 for me. I'm not sure if PSDRV_SelectBitmap() need to do more, but this is a start and it's better than a stub.
If it doesn't do more, then removing it completely should work just as well. There doesn't seem to be much point in just storing the bitmap, this is easy to retrieve when needed.
I looked a bit further, and it turns out PSDRV_SelectBitmap() returning only 0 will cause BITMAP_SelectObject() to not set dc->hBitmap (around line 609) and this is what's causing the print problem. I'm not using the HBITMAP, but simply storing it so PSDRV_SelectBitmap() can return a reasonable value. It looks like I can also fix the problem by not exporting a SelectBitmap() function from wineps.drv.