Re: [PATCH 1/4] opencl: Do not return an NTSTATUS from DllMain.

[Zebediah Figura (she/her)]

On 3/20/21 3:55 PM, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > Signed-off-by: Zebediah Figura
> >
> > dlls/opencl/pe_wrappers.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/dlls/opencl/pe_wrappers.c b/dlls/opencl/pe_wrappers.c
> > index 35c78181580..56ff204c900 100644
> > --- a/dlls/opencl/pe_wrappers.c
> > +++ b/dlls/opencl/pe_wrappers.c
> > @@ -132,7 +132,8 @@ BOOL WINAPI DllMain( HINSTANCE instance, DWORD reason, void *reserved )
> >      if (reason == DLL_PROCESS_ATTACH)
> >      {
> >          DisableThreadLibraryCalls( instance );
> > -
> >    return __wine_init_unix_lib( instance, reason, NULL, &opencl_funcs );
> > -
> >    if (__wine_init_unix_lib( instance, reason, NULL, &opencl_funcs ))
> > -
> >        ERR( "failed to load libOpenCL\n" );
>
> Sorry for screwing this up, but I still think the dll should fail to
> load without the Unix library, that's how it behaved previously.

Fair enough, I'll send an updated version.

Sorry for screwing this up on my end as well...