Am 08.02.2010 um 16:33 schrieb Matteo Bruni:
Other than the things Henri last mentioned, there are some more small changes (make some struct const/static, whitespace fixes, remove some useless cruft, ...) particularly in patches 2 and 3. <0001-d3dx9-Partial-implementation-of-D3DXAssembleShader-fun.txt>
Henri is on holidays this week(I think), here are 3 things I noticed:
- static const struct wpp_callbacks wpp_callbacks = {
wpp_lookup_mem,
wpp_open_mem,
The placement of the { is not consistent with the rest of the patch (and the entire patch 1 is inconsistent with patch 2 and 3). It seems to me the predominant style in d3dx9 is the one used by patch 1, although there are some inconsistencies.
+void wpp_write_message(const char *fmt, va_list args) +{
Unless I am missing some wpp magic here you can make this function(and others) static as well.
- Copyright 2009 Matteo Bruni
Maybe make this 2009-2010?