Alexandre Julliard julliard@winehq.org wrote:
So does that test behave differently for you with your patch? Does it show that things are fixed? Which font are you testing with?
The patch adds a missing else to the codepage tests in WineEngEnumFonts(), making it handle DEFAULT_CHARSET rather than ignore it.
As I pointed out in comment #49 to bug #7571 [1], this eventually revealed that either (a) there's a bug in our font loading functions, or (b) some fonts have some reserved bits set, which strikes me as odd.
I have tested the patch with quite a few fonts, including (but not limited to) Apple Garamond, Apple Garamond Light, Arial, Arial Black, Arrus BT, Arrus Blk BT, Calibri, Cambria, Candara, Consolas, Constantia, Corbel, Courier New, Segoe, Segoe Black, Segoe Light, Segoe Condensed, Segoe Print, Segoe UI, Times New Roman, and Trebuchet MS.
At least with those fonts (since I can't test every single font out there), the patch fixes the issue. And it passes Dmitry's tests.