31 Mar
2013
31 Mar
'13
9:08 a.m.
On 30 March 2013 23:50, Sam Edwards cfsworks@gmail.com wrote:
I'm a bit confused, then: Without this change, the exstyle test breaks, and the guidelines request that every patch be atomic. They also request that all tests be included in the same patch.
I'm not sure there really is such a rule.
Off the top of my head, I would guess it's one of these:
- The "all tests in the same patch" rule is only appropriate for single-patch submissions, so in multipatch patchsets, it's acceptable to include a final patch with nothing but tests.
- Only introduce the tests in the last patch of the patchset. (That is, add them all at once, but only when all of the necessary changes have been made to allow the tests to work first.)
- Include each test in the first patch that will allow the test to pass. (That is, add them incrementally.)
- Add the tests as todo_wine in the first patch, then remove the todo_wine in later patches as each test becomes functional. (That is, add them all at once as todo_wine, and mark them as non-todo incrementally.)
I think either or those is fine in principle, it depends a bit on the kind of test what's most practical. I guess that for this one you'll probably want 3.