Yes, I have done all of that. I’ve been rebasing for a few weeks.
I was just wondering that since changes were requested if there is something else I need to do to tell Gitlab “ok, I’m done” to put it back as available for merge?
I’ve marked all threads as resolved, but want to make sure there’s nothing else I need to do.
— Rob
On May 16, 2025, at 7:18 AM, Gerald Pfeifer gerald@pfeifer.com wrote:
On Thu, 15 May 2025, robert lippmann wrote:
I submitted a patch, and needed to make changes. I made the changes, but am not sure how to submit it for re-review.
Are you aware of https://gitlab.winehq.org/wine/wine/-/wikis/Git-Wine-Tutorial ?
Is there something I need to do to get it so it’s mergeable again? I’ve been rebasing for weeks. Should I just close the MR, and submit a new one?
https://gitlab.winehq.org/wine/wine/-/wikis/Git-Wine-Tutorial#updating-a-mer... specifically looks like it may be addressing your question?
I have successfully used these instructions myself a few times.
Hope this helps, Gerald