Re: [PATCH 1/3] windowscodecs: Add initial implementation of the GIF encoder.

[Dmitry Timoshkov]

"Esme Povirk (they/them)"  wrote:
> -
>    if (hr == S_OK)
> -
>        hr = write_source(iface, source, rc, format, 8, FALSE,
>
> This->width, This->height);
>
> I think needs_palette should probably be something like !This->colors.

Probably.
> -
>    if (state->user_write_data(state->user_ptr, &byte, 1) != 1)
> -
>        return 0;
>
> Why do we use this kind of abstraction for an internal function? Was
> this imported from another project?

It's my own development, but for a different target. I was using the LZW
encoder with a specially crafted tool, and after that adapted it for GIF.
If really necessary user_write() callback could be removed.
> If possible, I would prefer not to maintain an implementation of LZW
> compression.

Why? It's plain and simple. In comparison LZW decoder is more complicated,
but we have it included.