5 May
2022
5 May
'22
6:54 a.m.
On Thu May 5 00:35:50 2022 +0000, **** wrote:
Zebediah Figura (she/her) replied on the mailing list:
On 5/2/22 16:24, Rémi Bernon wrote: > From: Rémi Bernon <rbernon@codeweavers.com> > > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45988 > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47084 > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49715 > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52183 > Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> > --- > dlls/winegstreamer/wg_transform.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/dlls/winegstreamer/wg_transform.c b/dlls/winegstreamer/wg_transform.c > index 49c7bfaa927..58eb1286401 100644 > --- a/dlls/winegstreamer/wg_transform.c > +++ b/dlls/winegstreamer/wg_transform.c > @@ -389,7 +389,9 @@ static NTSTATUS read_transform_output_data(GstBuffer *buffer, struct wg_sample * > > memcpy(sample->data, info.data, sample->size); > gst_buffer_unmap(buffer, &info); > - gst_buffer_resize(buffer, sample->size, -1); > + > + if (sample->flags & WG_SAMPLE_FLAG_INCOMPLETE) > + gst_buffer_resize(buffer, sample->size, -1); > > GST_INFO("Copied %u bytes, sample %p, flags %#x", sample->size, sample, sample->flags); > return STATUS_SUCCESS; I guess this is fine, although it seems unnecessary? Is there a particular reason to do this?
Possibly avoiding whatever resize involves if it's not necessary, but I think some video buffers didn't expect to be resized.