2011/10/23 Jerome Leclanche adys.wh@gmail.com:
How would people feel if configure turned on -Werror when it's safe to if building from git? Something like this...
It's still unsafe, you're limited to a subset of gcc versions.
That's not too hard to check for:
--- a/configure.ac +++ b/configure.ac @@ -1715,6 +1715,19 @@ then if test "x$enable_maintainer_mode" = "xyes" then WINE_TRY_CFLAGS([-Werror]) + else + dnl Enable -Werror when building from git on 32 bit x86 with a known good version of gcc + case $host_cpu in + *i[[3456789]]86*) + if test "x${GCC}" = "xyes" && test -d $srcdir/.git + then + case `$(CC) -v 2>&1 | grep "gcc version" | sed 's/gcc version //' ` in + 4.[3456].*) + WINE_TRY_CFLAGS([-Werror]) ;; + esac + fi + ;; + esac fi
dnl Check for ms_hook_prologue support
Not worth it.
In which sense? Is it too hard to make it safe?
If it safely cuts down on the number of times people have to resubmit patches, why not do it? - Dan