June 15, 2021 12:39 AM, "Henri Verbeet" hverbeet@gmail.com wrote:
- || current->register_index > register_first
- || current->register_index + current->binding.count <= register_last)
continue;
"current->register_index + current->binding.count" can overflow.
The result would be it doesn't match any binding. We could emit an error, but I think overflow should be checked in d3d12_root_signature_append_vk_binding() in state.c. Other uses of vkd3d-shader could send this type of invalid binding, but I think the resulting "Could not find binding" is accurate enough.