On 3/22/2010 22:09, Paul Vriens wrote:
On 03/22/2010 01:01 PM, Nikolay Sivov wrote:
Implement some IShellFolderView methods over IFolderView
Hi Nikolay,
- /* ::MoveIcons */
- hr = IShellFolderView_MoveIcons(folderview, NULL);
- ok(hr == E_NOTIMPL, "got (0x%08x)\n", hr);
This one makes Win98 and win95 (both with shell32.dll version 4.72.x) crash.
I prefer to keep it for all platforms. We need stub IDataObject in tests for it. I'll try with a stub tomorrow maybe, if you could be faster please go ahead.
The same is true for the one from patch "Add IShellFolderView::SetRedraw implementation":
- /* ::SetRedraw without list created */
- hr = IShellFolderView_SetRedraw(folderview, TRUE);
- ok(hr == S_OK, "got (0x%08x)\n", hr);
(Changing TRUE to FALSE doesn't make this test crash!).
It's strange. Did you try it separately from others? If it's true there's no problem to change in to FALSE. It means nothing for this test.
There is nothing in those tests yet that indicates version 5.0 (if that's what makes these tests succeed) or higher. It's easy enough to skip on Win9x but that also means no tests or WinMe or don't we care in this case?
It's better to run them all.