Re: [PATCH 2/5] taskschd: Implement IDailyTrigger_put_StartBoundary.

[Hans Leidekker]

On Fri, 2017-12-01 at 18:02 +0800, Dmitry Timoshkov wrote:
> Hans Leidekker  wrote:
> > static HRESULT WINAPI DailyTrigger_put_StartBoundary(IDailyTrigger *iface, BSTR start)
> >  {
> >      DailyTrigger *This = impl_from_IDailyTrigger(iface);
> > - FIXME("(%p)->(%s)\n", This, debugstr_w(start));
> > - WCHAR *str = NULL;
> > -
> > - TRACE("(%p)->(%s)\n", This, debugstr_w(start));
> > -
> > - if (start && !(This->start_boundary = heap_strdupW(start))) return E_OUTOFMEMORY;
> > - heap_free(This->start_boundary);
> > - This->start_boundary = str;
> > - return S_OK;
> >
> > }
>
> Probably trigger time related data should be stored as a parsed system
> time instead of a string since all the further checks and calculations
> would need to be done with absolute time anyway. And the reverse conversion
> should be performed in get_StartBoundary().

No, it's stored as-is. I've added some tests to show that.