Dmitry Timoshkov wrote:
I don't see any corresponding changes in that patch that remove todo_wine statements in the tests. That suggests that either such tests don't exist, or that change actually fixes nothing.
A third explanation is possible: It's an example of one bug shadowing another bug.
There's no todo_wine to remove because a) No Notification was sent in Wine because the parser did not correctly handle system commands. MCI_Sound was never called so there was no notification. b) There was no need for todo_wine in the past because this double error could not be detected. No notification was and is the correct behaviour when the sound command returns an error, as it currently does. b) When I fixed that in "try 1", AJ observed the notification test failure. That's why I had to fix the notification as well for "try 2".
The tests pass on MS (in both MMSYS_NOERROR and MCIERR_HARDWARE modes) proving they are ok.
Regards, Jörg Höhle.