Re: [PATCH v2 4/7] ucrtbase: Implement the new printf corner case behaviour

[Martin Storsjö]

On Tue, 3 Nov 2015, Piotr Caban wrote:
> On 11/02/15 22:26, Martin Storsjo wrote:
> > - if (options & ~UCRTBASE_PRINTF_TERMINATION_MASK)
> > -
> >    FIXME("options %s not handled\n", wine_dbgstr_longlong(options));
>
> Shouldn't this be changed to:
> if(options & ~UCRTBASE_PRINTF_MASK)
>    FIXME("...);
> instead of being removed?

Perhaps, although these are all the flags that are currently defined, so 
as far as I can see, there's nothing left to warn about (unless someone 
calls this internal function deliberately with weird/undefined flags). 
(The mask when caling pf_printf is only to make sure that we don't 
accidentally alias the flags of our own.)

Should we keep a warning in case a future version adds more flags?

// Martin