"Andreas Mohr" andi@rhlx01.fht-esslingen.de wrote:
All the codecs except ir32_32 return dwVersionICM set to ICVERSION (0x0104), so that looks like a common practice. However dwVersion field doesn't look like a reasonably set at all. I decided to follow msrle32 and set to 0x0104 as well.
Sorry, bad decision IMHO. Everything indicates that ICVERSION is always used for dwVersionICM only, so you shouldn't give the impression that it could be used for dwVersion, too. IMHO it's much better to choose an arbitrary value for dwVersion with a FIXME comment behind it.
I don't see how a FIXME could improve Windows drivers behaviour to return arbitrary values in the dwVersion field. IMHO it's much better to use a definitive and reasonable one, and ICVERSION qualifies for that.