Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()

[Dmitry Timoshkov]

Nikolay Sivov  wrote:
> - if (!IsEqualGUID(&src_format, format))
> - {
> -
>    /* FIXME: should use WICConvertBitmapSource to convert */
> -
>    ERR("format %s unsupported\n", debugstr_guid(&src_format));
> -
>    return E_FAIL;
> -
>    hr = IWICBitmapFrameEncode_SetPixelFormat(iface, &src_format);
> -
>    if (FAILED(hr)) return hr;
> }

Despite the removing a questionable FIXME this part of the code won't do
what you think it does. Besides, since there is no a single todo_wine
removed with this patch adding a bunch of tests for different encoders
is needed to show that the automatic conversion is really supposed to
happen, and that it doesn't depend on the implementation detail in some
of the encoders. According to my testing not every encoder does this
kind of thing, especially when a conversion needs a palette.