Re: [PATCH vkd3d v2 2/6] vkd3d-shader: Write empty SM1 shaders.

[Zebediah Figura (she/her)]

On 4/20/21 9:30 AM, Henri Verbeet wrote:
> On Fri, 16 Apr 2021 at 02:04, Zebediah Figura  wrote:
> > +static void put_dword(struct bytecode_buffer *buffer, uint32_t value)
> > +{
> > - if (buffer->status)
> > -
> >    return;
> > -
> > - if (!vkd3d_array_reserve((void **)&buffer->data, &buffer->size, buffer->count + 1, sizeof(*buffer->data)))
> > - {
> > -
> >    buffer->status = VKD3D_ERROR_OUT_OF_MEMORY;
> > -
> >    return;
> > - }
> > - buffer->data[buffer->count++] = value;
> >
> > +}
> > -
>
> I'll leave it to Matteo and you to decide how much you care, but for
> consistency, perhaps "emit_u32()"?

I'm fine with this as well.