On 04.04.2015 11:07, Jianqiu Zhang wrote:
At 2015-04-04 15:17:13, "Nikolay Sivov" bunglehead@gmail.com wrote:
Hi, Jianqiu.
This is not exactly a test, as you're just printing a result. Same thing with patch 3/4. Also to print LONGLONG values you use wine_dbgstr_longlong() probably.
Hi~ Nikolay In fact , this is my first time to submit a patch to wine community :) I have a few questions to ask
That's perfectly normal, and you're welcome to ask.
What does a test do? I thought test functions is a kind of implementation of WinAPI . I write test function and build cross test executable file and then run on Windows to get some data I need . Then I can write the FileFsFullSizeInformation based on these data
Test calls some function or a set of functions, then checks for function output (could be return value or out arguments, or something indirectly affected by this call) using ok() statements. Then like you said, you make sure test works on Windows and then you make it work on Wine.
And you said that what I wrote is not a test.Does it mean I should test whether my new function works well? Should I use ok and todo macro to make my test convincing?
What I mean is that your test is supposed to actually check what function returns, not just print a result. Because if it only prints something we don't know if it's working or not, and tests output is not supposed to be visually examined. Basically you should use ok() for that.