Re: [PATCH 4/5] wined3d: Add shadow sampler capability bit to d3d_info.

[Józef Kucia]

On Thu, Aug 23, 2018 at 7:42 PM Henri Verbeet  wrote:
> On 23 August 2018 at 17:04, Józef Kucia  wrote:
> > Signed-off-by: Józef Kucia
> >
> > dlls/wined3d/adapter_gl.c      | 1 +
> >  dlls/wined3d/directx.c         | 2 +-
> >  dlls/wined3d/wined3d_private.h | 6 +++++-
> >  3 files changed, 7 insertions(+), 2 deletions(-)
>
> I'm not necessarily against this, but strictly speaking the
> "shadow_sampler" field is somewhat superfluous. I think we simply
> shouldn't be setting the WINED3DFMT_FLAG_TEXTURE flag if ARB_shadow
> isn't supported, in which case wined3d_check_device_format() could
> lose the special case.

It should be possible to not set the WINED3DFMT_FLAG_TEXTURE flag, but
it's a bit more invasive change. I'll take a look.