I resent because the first feedback was "one patch per email".
The first patch is from another developer. I want to make sure he gets credit for the work, and the only way I can see doing that is to cleanly separate his patch from mine. Since I started my work from there, it's the first patch.
All three (plus overriding OffscreenRenderingMode to 'fbo') are required to fix the bug 15839. As I said in the first commit, Mirek Slugen should be credited if there is only room for one author, since he diagnosed the bug and first started trying to get it submitted back in November.
On Tue, Apr 7, 2009 at 1:23 AM, Henri Verbeet hverbeet@gmail.com wrote:
2009/4/7 John Whitlock John-Whitlock@ieee.org:
- HeapFree(GetProcessHeap(), 0, wined3d_settings.video_driver);
- HeapFree(GetProcessHeap(), 0, wined3d_settings.video_description);
This should be part of the first patch. (And if you're going to resend anyway, I think it makes more sense to do the autodetection first, and the registry override afterwards).