On 28 September 2018 at 04:02, Francois Gouget fgouget@free.fr wrote:
On Fri, 28 Sep 2018, Henri Verbeet wrote:
I don't necessarily want to block this going in if you really care about this, but I also think the name-change is completely ridiculous.
You mean Apple's decision to change the name or the patch ;-)
Apple's decision.
The thing is that "MacOS X" is a misspelled form of "Mac OS X", the former OS name, so my script reports it as a typo[1]. And it is with spelling issues as with warnings or test failures: if you let them accumulate you soon cannot tell what's new from what's not[2].
So I can either change that to one of the official names or disable this specific check for Wine. So even though it's a minor issue I typically prefer to just send a patch once in a while. But I can disable this check if you prefer.
I guess what I'm saying is that I'm fine with this going in, but have reservations about endorsing it with a Signed-off-by.