Dmitry Timoshkov dmitry@baikal.ru writes:
Fabian Maurer dark.shadow4@web.de wrote:
I know they're intentionally formatted like that. But it causes a lot of compile warning, or errors when using -Werror. I don't think it should be that using todo_wine causes compile warnings. Sure, in a perfect world we'd never need todo_wine, but we're not in a perfect world and I want to avoid compile warnings.
Probably the compiler shouldn't emit this kind of warnings, and disabling the warning is another option, perhaps just in a local build if this kind of warnings bothers too much.
The warning did catch a few real issues, so I don't think we want to disable it. Yes, it will cause some code churn to reindent the todos, but it's only in tests so I think it's acceptable.
Alternative would be to manually add curly braces, this would make the compiler happy as well. But fixing the indentation seems more logical to me.
More logical seems fixing the place a todo_wine was added for.
Fixing all the todos is not a realistic option.