On Fri, Oct 10, 2008 at 2:52 PM, Andrey Turkin andrey.turkin@gmail.com wrote:
[few comments added as per James' suggestion]
Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW stubs and few tests for them. Required for MSN Messenger 7.0
dlls/advapi32/advapi32.spec | 4 +- dlls/advapi32/cred.c | 163 +++++++++++++++++++++++++++++++++++++++++++ dlls/advapi32/tests/cred.c | 52 ++++++++++++++ include/wincred.h | 39 ++++++++++ 4 files changed, 256 insertions(+), 2 deletions(-)
+ /* these two tests would crash on both native and Wine. Implementations
+ * does not check for NULL output pointers and try to zero them out early
+ ok(!pCredReadDomainCredentialsA(&info, 0, NULL, &creds) &&
+ GetLastError() == ERROR_INVALID_PARAMETER, "!");
+ ok(!pCredReadDomainCredentialsA(&info, 0, &count, NULL) &&
+ GetLastError() == ERROR_INVALID_PARAMETER, "!"); */
+
Please use if(0) instead of commenting them out.
+ if (pCredReadDomainCredentialsA) test_CredReadDomainCredentialsA();
This should be tested for in test_CredReadDomainCredentialsA, and a win_skip issued if the function is not available.