10 Jun
2022
10 Jun
'22
12:40 p.m.
On Fri Jun 10 10:25:14 2022 +0000, Rémi Bernon wrote:
I'd suggest to simply remove that racy `GetResult` check, but otherwise what about changing the check to `ok(hr == E_ILLEGAL_METHOD_CALL || hr == S_OK, ...)`, and then and putting the rest in an `if (hr == E_ILLEGAL_METHOD_CALL)` block? Gotos are more often used to skip tests after a todo_wine, so that implementing the call only require to remove the todo_wine and the goto, but for normal control flow I think ifs are better.
Yeah, an if block sounds cleaner. I'd like to keep the check though.