Re: [PATCH v2 2/3] mfplat: Add IMFAttributes interface to IMFByteStream.

[Nikolay Sivov]

On 11/02/2018 10:49 PM, Sven Baars wrote:
> typedef struct _mfbytestream
>   {
> - mfattributes attributes;
>  IMFByteStream IMFByteStream_iface;
> - IMFAttributes IMFAttributes_iface;
>  LONG ref;
> - } mfbytestream;

mfattributes already has IMFAttributes and refcount members.
> +static inline mfbytestream *impl_from_IMFByteStream_IMFAttributes(IMFAttributes *iface)
> +{
> - return CONTAINING_RECORD(iface, mfbytestream, IMFAttributes_iface);
>
> +}
> -
>
> +static HRESULT WINAPI mfbytestream_mfattributes_QueryInterface(
> - IMFAttributes *iface, REFIID riid, void **out)

With name like that I think it's better to move it to a separate file.