Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de writes:
PROPSHEET_CreatePage writes to ppshpage->u.pResource when PSP_DLGINDIRECT is set. MSDN also tells that applications will break if pResource is not writable. It seems that above patch maps the resource section write protected.
Actually it should be read-only, and the default exception handler is supposed to unprotect it to hide bugs in broken apps. But writing to resources is a bug in any case, and that propsheet code needs to be fixed. In fact there's already a hack in there to avoid the same issue with builtin resources; I guess it's really time to fix it properly.