Re: advapi32/tests: Test for last error after RegQueryValueEx

[Alexandre Julliard]

Nikolay Sivov  writes:
> On 2/26/2010 19:00, Alexandre Julliard wrote:
> > I'm not saying that you should remove it, but that you should set last
> > error to 0xdeadbeef to make it clear whether you are expecting it to be
> > unchanged or set to 0. Right now your test could mean either.
>
> Previous check is about the same thing, I reset to deadbeef and check
> for 0 after call. Second one is what application does, I wanted it as
> a passing test to show that error isn't changed from 0. It's ok to
> remove it.

The second one doesn't behave the same as the first one for me. Also
setting last error at all here is surprising, so I think you'll want
all the tests you can have.