Re: [PATCH v2 1/5] d3d11.idl: Add missing D3D11_DEVICE_CONTEXT_TYPE enums and D3D11_FEATURE_DATA_* declaration

[Henri Verbeet]

On 17 September 2017 at 07:39, Ihsan Akmal  wrote:
> +typedef enum D3D11_CONSERVATIVE_RASTERIZATION_TIER {
> - D3D11_CONSERVATIVE_RASTERIZATION_NOT_SUPPORTED = 0,
> - D3D11_CONSERVATIVE_RASTERIZATION_TIER_1 = 1,
> - D3D11_CONSERVATIVE_RASTERIZATION_TIER_2 = 2,
> - D3D11_CONSERVATIVE_RASTERIZATION_TIER_3 = 3,
>
> +} D3D11_CONSERVATIVE_RASTERIZATION_TIER;
> -
> -
>
> +typedef struct D3D11_FEATURE_DATA_D3D11_OPTIONS2
> +{
> - BOOL PSSpecifiedStencilRefSupported;
> - BOOL TypedUAVLoadAdditionalFormats;
> - BOOL ROVsSupported;
> - D3D11_CONSERVATIVE_RASTERIZATION_TIER ConservativeRasterizationTier;
> - D3D11_TILED_RESOURCES_TIER TiledResourcesTier;
> - BOOL MapOnDefaultTextures;
> - BOOL StandardSwizzle;
> - BOOL UnifiedMemoryArchitecture;
>
> +} D3D11_FEATURE_DATA_D3D11_OPTIONS2;
> -
> -

The formatting is inconsistent here.
> +typedef enum D3D11_SHADER_CACHE_SUPPORT_FLAGS
> +{
> - D3D11_SHADER_CACHE_SUPPORT_NONE = 0x0,
> - D3D11_SHADER_CACHE_SUPPORT_AUTOMATIC_INPROC_CACHE = 0x1,
> - D3D11_SHADER_CACHE_SUPPORT_AUTOMATIC_DISK_CACHE = 0x2,
>
> +} D3D11_SHADER_CACHE_SUPPORT_FLAGS;
> -
>
> +typedef struct D3D11_FEATURE_DATA_SHADER_CACHE
> +{
> - UINT SupportFlags;
>
> +} D3D11_FEATURE_DATA_SHADER_CACHE;

Should "SupportFlags" be of type D3D11_SHADER_CACHE_SUPPORT_FLAGS?