On Sat, 11 Apr 2020, Zebediah Figura wrote: [...]
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=69375
[...]
None of these test failures are in the added tests (and a whitespace patch produces most of the same ones).
I do find it odd, however, that so many of these tests fail when run with the testbot, whereas none show up on test.winehq.org. Maybe it's a winetest vs testlauncher issue?
That does not seem likely. Both WineTest and TestLauncher perform some checks to decide whether to run the test but then it's just CreateProcess()+WaitFor*Object():
https://source.winehq.org/git/wine.git/blob/HEAD:/programs/winetest/main.c#l... https://source.winehq.org/git/tools.git/blob/HEAD:/testbot/src/TestLauncher/...
WineTest does specify the current directory but that does not seem likely to cause wait timeouts (and in any case tests should work no matter what the initial cwd is).
I think it's more a difference in VM uptime: in the WineTest case the VM has been up and running for 5-10 minutes by the time it runs the ntdll tests, whereas in the standalone case it has been up for seconds at most.