Re: winhttp/tests: Use BOOL type where appropriate

[Dmitry Timoshkov]

Bruno Jesus  wrote:
> > > --- a/dlls/winhttp/tests/notification.c
> > > +++ b/dlls/winhttp/tests/notification.c
> > > @@ -44,9 +44,9 @@ struct notification
> > >  {
> > >      enum api function;      /* api responsible for notification */
> > >      unsigned int status;    /* status received */
> > > - int todo;
> > > - int ignore;
> > > - int skipped_for_proxy;
> > > - BOOL todo;
> > > - BOOL ignore;
> > > - BOOL skipped_for_proxy;
> >
> > Do you realize that BOOL is typedef'ed to int and therefore your patches
> > do basically nothing? Is there any real reason behind these patches?
>
> Hi, Dmitry. This has been discussed before, here is an example:
> http://osdir.com/ml/wine-devel/2013-10/msg00131.html

I don't think that qualifies as a "discussion" :) Besides the using
Windows-only BOOL type these patches break the git history and don't
add any advertized clarity IMHO.