Dmitry Timoshkov dmitry@baikal.ru writes:
Alexandre Julliard julliard@winehq.org wrote:
Maybe it would still be testing the same thing, but moving the tests out of WM_INITDIALOG would make things clearer.
That would complicate things for no reason and wouldn't chage anything. For instance moving the tests out of WM_INITDIALOG to WM_ENTERIDLE would make the tests actually test different behaviour than it was originally intended.
Avoiding changing the window creation of existing tests would be a good thing too.
Since I am an original author of existing tests I don't think that adding another hoop to jump trough (make the tests cope with NULL parent) would change anything for existing tests since this wouldn't change the dialog styles.
Never mind then.
Could you please resubmit at least with the todos fixed?