On 8/26/21 9:33 PM, Dmitry Timoshkov wrote:
Hi Jacek,
Thanks for the review.
Jacek Caban jacek@codeweavers.com wrote:
@@ -1583,7 +1586,7 @@ static void test_InternetErrorDlg(void) expected = ERROR_INVALID_PARAMETER;
res = InternetErrorDlg(hwnd, NULL, i, FLAGS_ERROR_UI_FLAGS_NO_UI, NULL);
todo_wine_if( test_flags & FLAG_TODO || i == ERROR_INTERNET_INCORRECT_PASSWORD)
todo_wine_if ((test_flags & FLAG_TODO) || i == ERROR_INTERNET_INCORRECT_PASSWORD || i == ERROR_INTERNET_INSERT_CDROM || i == ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED)Is there a reason why you don't use FLAG_TODO for those? It may not match what you need for your new tests, but why are you changing half of its usage here?
Because using FLAG_TODO is fragile due to inconsistent behaviour, and it fails in new or old tests. I tried different approaches in hope to make it more clean and less controvercial regarding FLAG_TODO usage, but finally decided to have it this way. I'm still open to suggestions though, however I haven't found anything better while changing the tests to follow recent Windows behaviour.
If you remove most of them, then you may remove all of them as well. If you remove most of them, you may as well replace the existing mechanism. How about something like this:
https://testbot.winehq.org/JobDetails.pl?Key=96801
Thanks,
Jacek