note for reviewers: - there are a couple of places where a macro (like expect) is used and is passed several types of pair (expected vs actual) (mostly the four configurations int vs long on both parameters are seen) - I tested several approaches (like split expect in two expect_in and expect_long, moving to a typed approach like compare macro), but didn't apply them (still requiring too many casts in my opinion), didn't even consider others (cast everywhere), and finally used an helper function for the macro and letting the compiler do the integral conversion (hence hidding all the discrepancies in types we may have)
Especially for comctl32: - I forgot to mention in patch change, but the COLORREF casts in patch for include/commctrl.h are removed in next patch
A+ ---
Eric Pouech (31): dlls/winecrt0: enable compilation with long types dlls/comctl32/tests: use correct integral type dlls/comctl32/tests: use inline function in expect*() macros to handle integral conversion include/commctrl.h: fix definition of CLR_* macros dlls/comctl32/tests: enable compilation with long types dlls/d3d10core/tests: enable compilation with long types dlls/dbghelp/tests: enable compilation with long types dlls/ddrawex/tests: enable compilation with long types dlls/ddraw/tests: enable compilation with long types dlls/devenum/tests: enable compilation with long types dlls/dhcpcsvc/tests: enable compilation with long types dlls/directmanipulation/tests: enable compilation with long types include/ddraw.h: fix some definitions dlls/dplayx/tests: use correct integral type dlls/dplayx/tests: use function in checkFlags macro to handle integral conversion dlls/dplayx/tests: enable compilation with long types dlls/dpnet/tests: use correct integral type dlls/dpnet/tests: enable compilation with long types dlls/dpvoice/tests: enable compilation with long types dlls/dsdmo/tests: enable compilation with long types dlls/dsound/tests: enable compilation with long types dlls/dssenh/tests: enable compilation with long types dlls/dwmapi/tests: enable compilation with long types dlls/dwrite/tests: use correct integral type dlls/dwrite/tests: enable compilation with long types dlls/dxdiagn/tests: enable compilation with long types dlls/dxgi/tests: enable compilation with long types dlls/explorerframe/tests: use correct integral type dlls/explorerframe/tests: enable compilation with long types dlls/faultrep/tests: enable compilation with long types dlls/fusion/tests: enable compilation with long types
dlls/comctl32/tests/Makefile.in | 1 - dlls/comctl32/tests/animate.c | 4 +- dlls/comctl32/tests/button.c | 196 +- dlls/comctl32/tests/combo.c | 114 +- dlls/comctl32/tests/datetime.c | 62 +- dlls/comctl32/tests/dpa.c | 72 +- dlls/comctl32/tests/edit.c | 203 +- dlls/comctl32/tests/header.c | 78 +- dlls/comctl32/tests/imagelist.c | 120 +- dlls/comctl32/tests/listbox.c | 226 +- dlls/comctl32/tests/listview.c | 150 +- dlls/comctl32/tests/misc.c | 58 +- dlls/comctl32/tests/monthcal.c | 49 +- dlls/comctl32/tests/mru.c | 28 +- dlls/comctl32/tests/msg.h | 16 +- dlls/comctl32/tests/pager.c | 32 +- dlls/comctl32/tests/progress.c | 12 +- dlls/comctl32/tests/propsheet.c | 84 +- dlls/comctl32/tests/rebar.c | 22 +- dlls/comctl32/tests/static.c | 4 +- dlls/comctl32/tests/status.c | 13 +- dlls/comctl32/tests/subclass.c | 2 +- dlls/comctl32/tests/syslink.c | 10 +- dlls/comctl32/tests/tab.c | 45 +- dlls/comctl32/tests/taskdialog.c | 16 +- dlls/comctl32/tests/toolbar.c | 184 +- dlls/comctl32/tests/tooltips.c | 82 +- dlls/comctl32/tests/trackbar.c | 15 +- dlls/comctl32/tests/treeview.c | 62 +- dlls/comctl32/tests/updown.c | 26 +- dlls/comctl32/tests/v6util.h | 4 +- dlls/d3d10core/tests/Makefile.in | 1 - dlls/d3d10core/tests/d3d10core.c | 1524 ++--- dlls/dbghelp/tests/Makefile.in | 1 - dlls/dbghelp/tests/dbghelp.c | 10 +- dlls/ddraw/tests/Makefile.in | 1 - dlls/ddraw/tests/d3d.c | 620 +- dlls/ddraw/tests/ddraw1.c | 4082 ++++++------- dlls/ddraw/tests/ddraw2.c | 4704 +++++++-------- dlls/ddraw/tests/ddraw4.c | 5648 +++++++++--------- dlls/ddraw/tests/ddraw7.c | 5360 ++++++++--------- dlls/ddraw/tests/ddrawmodes.c | 182 +- dlls/ddraw/tests/dsurface.c | 752 +-- dlls/ddraw/tests/refcount.c | 126 +- dlls/ddraw/tests/visual.c | 448 +- dlls/ddrawex/tests/Makefile.in | 1 - dlls/ddrawex/tests/ddrawex.c | 18 +- dlls/ddrawex/tests/surface.c | 100 +- dlls/devenum/tests/Makefile.in | 1 - dlls/devenum/tests/devenum.c | 266 +- dlls/dhcpcsvc/tests/Makefile.in | 1 - dlls/dhcpcsvc/tests/dhcpcsvc.c | 18 +- dlls/directmanipulation/tests/Makefile.in | 1 - dlls/directmanipulation/tests/manipulation.c | 4 +- dlls/dplayx/tests/Makefile.in | 1 - dlls/dplayx/tests/dplayx.c | 133 +- dlls/dpnet/tests/Makefile.in | 1 - dlls/dpnet/tests/address.c | 194 +- dlls/dpnet/tests/client.c | 362 +- dlls/dpnet/tests/server.c | 85 +- dlls/dpnet/tests/thread.c | 108 +- dlls/dpvoice/tests/Makefile.in | 1 - dlls/dpvoice/tests/voice.c | 100 +- dlls/dsdmo/tests/Makefile.in | 1 - dlls/dsdmo/tests/dsdmo.c | 170 +- dlls/dsound/tests/Makefile.in | 1 - dlls/dsound/tests/capture.c | 150 +- dlls/dsound/tests/ds3d.c | 250 +- dlls/dsound/tests/ds3d8.c | 238 +- dlls/dsound/tests/dsound.c | 386 +- dlls/dsound/tests/dsound8.c | 426 +- dlls/dsound/tests/duplex.c | 76 +- dlls/dsound/tests/propset.c | 124 +- dlls/dssenh/tests/Makefile.in | 1 - dlls/dssenh/tests/dssenh.c | 254 +- dlls/dwmapi/tests/Makefile.in | 1 - dlls/dwmapi/tests/dwmapi.c | 4 +- dlls/dwrite/tests/Makefile.in | 1 - dlls/dwrite/tests/analyzer.c | 196 +- dlls/dwrite/tests/font.c | 1848 +++--- dlls/dwrite/tests/layout.c | 1428 ++--- dlls/dxdiagn/tests/Makefile.in | 1 - dlls/dxdiagn/tests/container.c | 174 +- dlls/dxdiagn/tests/provider.c | 30 +- dlls/dxgi/tests/Makefile.in | 1 - dlls/dxgi/tests/dxgi.c | 1590 ++--- dlls/explorerframe/tests/Makefile.in | 1 - dlls/explorerframe/tests/nstc.c | 606 +- dlls/explorerframe/tests/taskbarlist.c | 66 +- dlls/faultrep/tests/Makefile.in | 1 - dlls/faultrep/tests/faultrep.c | 8 +- dlls/fusion/tests/Makefile.in | 1 - dlls/fusion/tests/asmcache.c | 344 +- dlls/fusion/tests/asmenum.c | 82 +- dlls/fusion/tests/asmname.c | 316 +- dlls/fusion/tests/fusion.c | 22 +- dlls/winecrt0/Makefile.in | 1 - dlls/winecrt0/debug.c | 6 +- include/commctrl.h | 4 +- include/ddraw.h | 22 +- 100 files changed, 17856 insertions(+), 17819 deletions(-)