On Thu, 13 Mar 2003, Jon Griffiths wrote:
Hence my suggestion to only use MESSAGE and DPRINTF inside dumping functions that can be elimated with macros. But as far as cosmetics go, i don't see how TMSG and TMS2 are any more ugly than MESSAGE. Check the code before the patch, its just as bad...
True, the original sin is the way the file was written. However, Alexandre just posted a wonderful patch which allows us to rewrite it in a sane manner.
If a rewrite is not feasible now, we'd better leave it as is, rather than do all this ugly gymnastics.