Re: [v2] Add a GUI for dxdiag program

[Matteo Bruni]

2016-09-01 21:56 GMT+02:00 Ruslan Kabatsayev :
> Hello,
>
> On Thu, Sep 1, 2016 at 9:21 PM, Matteo Bruni  wrote:
> > first of all, I think this patch should be splitted. For example, you
> > could split the "save all information" button functionality, together
> > with the common dialog include and dll linkage, to a separate patch.
>
> Hmm, and disable the Save button until that patch?..

That's okay, yes.
> > Also you don't need to cast, just use
> > MAKEINTRESOURCEW() (see for example notepad/dialog.c).
>
> I did at first, but with gcc 5 I got ugly warnings.

Ah, interesting. Does notepad also generate those warnings?