Re: [PATCH 2/5] amstream: Implement AMAudioStream::BeginFlush and ::EndFlush.

[Zebediah Figura]

On 6/1/20 11:13 PM, Anton Baskanov wrote:
> - static const WAVEFORMATEX format =
> - {
> -
>    .wFormatTag = WAVE_FORMAT_PCM,
> -
>    .nChannels = 1,
> -
>    .nSamplesPerSec = 11025,
> -
>    .wBitsPerSample = 16,
> -
>    .nBlockAlign = 2,
> -
>    .nAvgBytesPerSec = 2 * 11025,
> - };
> -
> - const AM_MEDIA_TYPE mt =
> - {
> -
>    .majortype = MEDIATYPE_Audio,
> -
>    .subtype = MEDIASUBTYPE_PCM,
> -
>    .formattype = FORMAT_WaveFormatEx,
> -
>    .cbFormat = sizeof(WAVEFORMATEX),
> -
>    .pbFormat = (BYTE *)&format,
> - };
> -
> - IAMMultiMediaStream *mmstream = create_ammultimediastream();
> - IAudioStreamSample *stream_sample;
> - IAudioMediaStream *audio_stream;
> - IMediaSample *media_sample;
> - struct testfilter source;
> - IAudioData *audio_data;
> - IGraphBuilder *graph;
> - IMediaStream *stream;
> - HRESULT hr;
> - ULONG ref;
> - IPin *pin;
> -
> - hr = IAMMultiMediaStream_Initialize(mmstream, STREAMTYPE_READ, 0, NULL);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IAMMultiMediaStream_AddMediaStream(mmstream, NULL, &MSPID_PrimaryAudio, 0, &stream);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IMediaStream_QueryInterface(stream, &IID_IAudioMediaStream, (void **)&audio_stream);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IMediaStream_QueryInterface(stream, &IID_IPin, (void **)&pin);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IAMMultiMediaStream_GetFilterGraph(mmstream, &graph);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - ok(graph != NULL, "Expected non-NULL graph.\n");
> - testfilter_init(&source);
> - hr = IGraphBuilder_AddFilter(graph, &source.filter.IBaseFilter_iface, NULL);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = CoCreateInstance(&CLSID_AMAudioData, NULL, CLSCTX_INPROC_SERVER, &IID_IAudioData, (void **)&audio_data);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IAudioData_SetBuffer(audio_data, 16, NULL, 0);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IAudioMediaStream_CreateSample(audio_stream, audio_data, 0, &stream_sample);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - hr = IGraphBuilder_ConnectDirect(graph, &source.source.pin.IPin_iface, pin, &mt);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - hr = IAMMultiMediaStream_SetState(mmstream, STREAMSTATE_RUN);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - hr = BaseOutputPinImpl_GetDeliveryBuffer(&source.source, &media_sample, NULL, NULL, 0);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IMemInputPin_Receive(source.source.pMemInputPin, media_sample);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - ref = get_refcount(media_sample);
> - ok(ref == 2, "Got unexpected refcount %d.\n", ref);
> -
> - hr = IPin_EndOfStream(pin);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - hr = IPin_BeginFlush(pin);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - ref = IMediaSample_Release(media_sample);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> -
> - hr = BaseOutputPinImpl_GetDeliveryBuffer(&source.source, &media_sample, NULL, NULL, 0);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IMemInputPin_Receive(source.source.pMemInputPin, media_sample);
> - ok(hr == S_FALSE, "Got hr %#x.\n", hr);
> -
> - ref = IMediaSample_Release(media_sample);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> -
> - hr = IAudioStreamSample_Update(stream_sample, SSUPDATE_ASYNC, NULL, NULL, 0);
> - ok(hr == MS_S_PENDING, "Got hr %#x.\n", hr);
> -
> - hr = IPin_EndOfStream(pin);
> - ok(hr == E_FAIL, "Got hr %#x.\n", hr);
> -
> - hr = IPin_EndFlush(pin);

Looks like you accidentally missed an ok() call here.
> -
> - hr = BaseOutputPinImpl_GetDeliveryBuffer(&source.source, &media_sample, NULL, NULL, 0);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - hr = IMemInputPin_Receive(source.source.pMemInputPin, media_sample);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> - ref = IMediaSample_Release(media_sample);
> - ok(ref == 1, "Got outstanding refcount %d.\n", ref);
> -
> - hr = IPin_EndOfStream(pin);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - hr = IAMMultiMediaStream_SetState(mmstream, STREAMSTATE_STOP);
> - ok(hr == S_OK, "Got hr %#x.\n", hr);
> -
> - IGraphBuilder_Disconnect(graph, pin);
> - IGraphBuilder_Disconnect(graph, &source.source.pin.IPin_iface);
> -
> - ref = IAudioStreamSample_Release(stream_sample);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> - ref = IAudioData_Release(audio_data);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> - ref = IAMMultiMediaStream_Release(mmstream);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> - ref = IGraphBuilder_Release(graph);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
> - IPin_Release(pin);
> - IAudioMediaStream_Release(audio_stream);
> - ref = IMediaStream_Release(stream);
> - ok(!ref, "Got outstanding refcount %d.\n", ref);
>
> +}
> -
>
> static void CALLBACK apc_func(ULONG_PTR param)
>  {
>  }